Author: Olivier Langlois 2013-10-04 03:23:49
Published on: 2013-10-04T03:23:49+00:00
Upon examining the CDB:Rewrite() code in db.h and db.cpp files, it was discovered that while it is declared as bool static in db.h, it isn't so in db.cpp. It is unclear whether this is a problem or an intentional feature. However, the code has been determined to be perfect C++ code.CDB:Rewrite() is called only in wallet.cpp, specifically in CWallet::EncryptWallet(), but its return value is ignored. It is uncertain whether this is intentional or a bug. This may be considered a minor bug since over 99% of the time the function is called, it succeeds. One possible solution could be for CWallet::EncryptWallet() to return false to its callers when CDB::Rewrite fails.
Updated on: 2023-06-07T17:19:56.387602+00:00