Author: Mem Wallet 2014-11-27 17:27:59
Published on: 2014-11-27T17:27:59+00:00
In the context provided, two minor observations have been made regarding the libbitcoin_common.a library. Firstly, DecodeBase58Check is listed as inline in the header but is not actually inlined, making it both non-present in libbitcoin_common.a and unavailable to other code that would use it as a library. This has been identified as a potential bug. Secondly, the hierarchy of tools within the library is poor/weak, with base58.h being an example of an independent low level math/string library that includes caddress, requiring chainparams and making the whole dependency tree quite involved. The question arises whether there is an intention to strengthen and hierarchicalize the various internal libraries such that they would be suitable for third-party development of bitcoin-related services and tools. It is unclear whether this is a goal or if some other project would have to fill such a role.
Updated on: 2023-06-09T14:29:20.058587+00:00